Make Container/Component techn optional #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the `techn` argument to `Container` and friends optional, similar to how it is optional in `Rel`. I am not very familiar with this project or plantuml in general, so please review carefully.
Member
|
thank you for the PR. Can you please update the Component and documentation too? Related to documentation: Thank you and best regards |
kirchsth
requested changes
Mar 20, 2022
Contributor
Author
|
I have addressed the comments. Also made the changes to make the |
kirchsth
approved these changes
Mar 21, 2022
Member
|
@netrounds-fredrik thank you for the PR |
kirchsth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
technargument toContainerand friends optional, similar to how it is optional inRel.I am not very familiar with this project or plantuml in general, so please review carefully.