add missing runtime dependencies #306
Conversation
Flask-rebar uses type classes not available in all supported python versions. Missing type classes are imported from typing-extensions. Signed-off-by: Valentin Kunz <[email protected]>
Type class ParamSpec was made available with python3.10. Limit polyfill import to python versions missing ParamSpec. Signed-off-by: Valentin Kunz <[email protected]>
Polyfills within typing-extensions dependency are only used within specific python versions. Limit the dependency to those specific versions. Signed-off-by: Valentin Kunz <[email protected]>
Bits from this module are used directly within flask-rebar. Signed-off-by: Valentin Kunz <[email protected]>
|
@vkunz -- Sorry for the delayed response, thanks for the contribution, we really appreciate it! Your changes look good to me, but unfortunately It looks like tests are failing for issues unrelated to your changes -- I'd like for us to fix those underlying issues and ensure that those tests pass, and then rebase your changes on top of those fixes and make sure they pass those tests as well, if that's ok with you? We should be able to get those fixes in by (and likely on) Friday, March 26th Pacific Standard Time. |
no worries
sure, that's okay
I have a locally working fix here I could submit but only if you'd like me to. I wouldn't want to step on anybodies toes. BR, |
|
@vkunz -- thanks for offering a second fix! No worries about stepping on any toes, contributions are always welcome. It looks like Verina was able to get those changes in already, and your changes are now passing, so we'll go ahead and merge this PR. Thank you again for the contribution! |
hi,
flask-rebar uses bits from dependent modules without declaring the proper dependency.
Full disclosure: I am not super fluent in python, so this might not be the python way of fixing this.
Only commit f73264e is strictly necessary, everything else should be considered rfc.
I started a fresh flask/flask-rebar project. Running the built-in development server of flask complained about imports from missing modules.
BR,
Valentin