Skip to content

DO NOT MERGE: Reserved connections#65

Closed
deepthi wants to merge 6 commits intomasterfrom
reserved-connections
Closed

DO NOT MERGE: Reserved connections#65
deepthi wants to merge 6 commits intomasterfrom
reserved-connections

Conversation

@deepthi
Copy link
Copy Markdown

@deepthi deepthi commented Jun 3, 2020

Creating a PR for collaboration.

@deepthi deepthi requested a review from sougou as a code owner June 3, 2020 00:07
@deepthi
Copy link
Copy Markdown
Author

deepthi commented Jun 3, 2020 •
edited
Loading

The new interfaces need review before we go further.
Next step is to decide whether to add ConnectionID to the request/response protobufs (query.ExecuteRequest etc.). That will change the gRPC interface, but without that we cannot fix this error:

# vitess.io/vitess/go/vt/vttablet/grpctabletconn
go/vt/vttablet/grpctabletconn/conn.go:88:2: cannot use result (type *gRPCQueryClient) as type "vitess.io/vitess/go/vt/vttablet/queryservice".QueryService in return argument:
	*gRPCQueryClient does not implement "vitess.io/vitess/go/vt/vttablet/queryservice".QueryService (wrong type for BeginExecute method)
		have BeginExecute("context".Context, *query.Target, string, map[string]*query.BindVariable, *query.ExecuteOptions) (*sqltypes.Result, int64, *topodata.TabletAlias, error)
		want BeginExecute("context".Context, *query.Target, string, map[string]*query.BindVariable, int64, *query.ExecuteOptions) (*sqltypes.Result, int64, *topodata.TabletAlias,

@deepthi deepthi requested a review from systay June 3, 2020 00:11
@deepthi deepthi marked this pull request as draft June 3, 2020 00:11
@deepthi deepthi force-pushed the reserved-connections branch 2 times, most recently from 825d381 to 3cf5c87 Compare June 3, 2020 21:20
@systay systay force-pushed the reserved-connections branch from 6e017af to 76c5a1d Compare June 4, 2020 14:09
systay added 2 commits June 5, 2020 14:30
@systay
Fixes vitessio#6266
e65e5e8 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Merge pull request vitessio#6270 from systay/issue6266
2553d59 
Make multi line inserts safer against bind var collisions
@systay systay force-pushed the reserved-connections branch from 62171a9 to 9a11323 Compare June 5, 2020 13:47
deepthi and others added 4 commits June 5, 2020 15:49
@deepthi @systay
reserved-connections: add Reserve funcs to QueryService interface
b008d12 
Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi @systay
reserved-connections: update interface with correct signatures, creat…
5992337 
…e Request/Response protos, add reserved_id to ShardSession

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
reserved-connections: prepare scatter_conn for reserved connections
e149a98 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi @systay
reserved-connections: fix error handling
ace96ef 
Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the reserved-connections branch from 9a11323 to ace96ef Compare June 5, 2020 13:49
@systay
Copy link
Copy Markdown
Member

systay commented Jun 5, 2020

Re-opening on the public Vitess repo vitessio#6274

@systay systay closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sougou sougou Awaiting requested review from sougou

@systay systay Awaiting requested review from systay

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deepthi @systay