Skip to content

Fixed "vttablet --help" to show correct command line flags#2

Closed
rasikakale wants to merge 6 commits intomasterfrom
rk-vttablet-command-line-flags
Closed

Fixed "vttablet --help" to show correct command line flags#2
rasikakale wants to merge 6 commits intomasterfrom
rk-vttablet-command-line-flags

Conversation

@rasikakale
Copy link

I fixed the vttablet --help error which gave flags that were not operable for other apps by doing the following fixes:

  • Created testhandler and staticauthserver package within mysql package

  • testhandler contains the following files that I moved from mysql into this package:
    - conn_test.go
    - query_test.go
    - replication_test.go
    - testhandler.go (contains TestHandler type originally part of mysql/query_benchmark_test.go)

  • staticauthserver contains the following files also moved from mysql into this package:
    - auth_server_static_test.go
    - auth_server_static.go

  • These files were moved from the mysql package to the endtoend package:
    - handshake_test.go
    - server_test.go
    - auth_server_clientcert_test.go

  • static_user_data.go file added to the mysql package that contains the StaticUserData type originally in staticauthserver/auth_server_static.go

  • I added prefixes of the appropriate package name in front of functions that are called outside of the package they are located in
    - e.g. A function RegisterAuthServerImpl() is defined in mysql/auth_server.go but called in staticauthserver/auth_server_static.go. The appropriate fix would be mysql.RegisterAuthServerImpl()

fixes: vitessio#4932

Signed-off-by: Rasika Kale rasika@planetscale.com

… moved/edit files to fix leaks

Signed-off-by: Rasika Kale <rasika@planetscale.com>
@rasikakale rasikakale requested a review from sougou as a code owner July 19, 2019 19:55
Rasika Kale added 5 commits July 19, 2019 13:34
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
@rasikakale rasikakale closed this Jul 19, 2019
arindamnayak added a commit that referenced this pull request Oct 23, 2019
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
morgo pushed a commit that referenced this pull request Mar 31, 2020
systay pushed a commit that referenced this pull request May 6, 2021
…ion/cancellation

This is a combination of 4 commits.
This is the commit message #2:

Check that routing rules are deleted in unit test

This is the commit message #3:

Fix typo

This is the commit message #4:

Refresh all tablets in a shard when updating blacklisted tables

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
mattlord added a commit that referenced this pull request Jun 29, 2022
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord added a commit that referenced this pull request Jul 3, 2022
* Implement VDiff2 delete command

Also add --verbose flag for VDiff output

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Delete vdiff metadata associated with a deleted workflow

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Tweaks after self review

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Self review #2

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Spelling is herd

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Add test for vdiff data cleanup on workflow deletion

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Caught mistake on self-review #3

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Add a couple more delete tests

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Clear out vdiff_log table as well on workflow deletion

Signed-off-by: Matt Lord <mattalord@gmail.com>
harshit-gangal pushed a commit that referenced this pull request Sep 7, 2022
* decouple olap tx timeout from oltp tx timeout

Since workload=olap bypasses the query timeouts
(--queryserver-config-query-timeout) and also row limits, the natural
assumption is that it also bypasses the transaction timeout.

This is not the case, e.g. for a tablet where the
--queryserver-config-transaction-timeout is 10.

This commit:

 * Adds new CLI flag and YAML field to independently configure TX
   timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout).
 * Decouples TX kill interval from OLTP TX timeout via new CLI flag and
   YAML field (--queryserver-config-transaction-killer-interval).

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #1

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #2 consolidate timeout logic in sc

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: remove unused tx killer flag

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: fix race cond

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #3 -txProps.timeout, +sc.expiryTime

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #4 -atomic.Value for expiryTime

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value)

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #5 -unused funcs, fix comments, set ticks interval once

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #5 +txkill tests

Signed-off-by: Max Englander <max@planetscale.com>

* revert fmt changes

Signed-off-by: Max Englander <max@planetscale.com>

* implement pr review suggestion

Signed-off-by: Max Englander <max@planetscale.com>

Signed-off-by: Max Englander <max@planetscale.com>
notfelineit pushed a commit that referenced this pull request Sep 21, 2022
* decouple olap tx timeout from oltp tx timeout

Since workload=olap bypasses the query timeouts
(--queryserver-config-query-timeout) and also row limits, the natural
assumption is that it also bypasses the transaction timeout.

This is not the case, e.g. for a tablet where the
--queryserver-config-transaction-timeout is 10.

This commit:

 * Adds new CLI flag and YAML field to independently configure TX
   timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout).
 * Decouples TX kill interval from OLTP TX timeout via new CLI flag and
   YAML field (--queryserver-config-transaction-killer-interval).

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #1

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #2 consolidate timeout logic in sc

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: remove unused tx killer flag

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: fix race cond

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #3 -txProps.timeout, +sc.expiryTime

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #4 -atomic.Value for expiryTime

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value)

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #5 -unused funcs, fix comments, set ticks interval once

Signed-off-by: Max Englander <max@planetscale.com>

* decouple ol{a,t}p tx timeouts: pr comments #5 +txkill tests

Signed-off-by: Max Englander <max@planetscale.com>

* fix flags

Signed-off-by: Max Englander <max@planetscale.com>

Signed-off-by: Max Englander <max@planetscale.com>
dbussink pushed a commit that referenced this pull request May 2, 2023
)

* Cleanup tx_throttler.go

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Cleanup tx_throttler.go #2

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix throttlerFactoryFunc

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Undo if-cond consolidation

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Undo struct shuffling

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* prove that disabled config returns nil error

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Improve test

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"vttablet --help" shows incorrect command line flags

1 participant