Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Collaborator
Author
|
@dbussink for review as this introduces |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
changed the title
dbussink
requested changes
Feb 22, 2024
pkg/core/exec.go
Outdated
| parser, err := sqlparser.New(sqlparser.Options{ | ||
| vtenv, err := vtenv.New(vtenv.Options{ | ||
| MySQLServerVersion: mysqlVersion, | ||
| TruncateUILen: servenv.TruncateUILen, |
Contributor
There was a problem hiding this comment.
We should not use servenv here but provide these values ourselves.
The defaults of 0 are actually fine and better. It also will clean up go.mod again and greatly reduce the binary size.
dbussink
approved these changes
Feb 22, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating
vitess.io/vitessto latest from upstream:v0.10.3-0.20240215220334-f82fb7cbd03d. This specifically includes foreign key loop resolution.Update to the update: now pulling
v0.10.3-0.20240222075616-c536bb7b2660which specifically includes vitessio/vitess#15302.