This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
replace import * with named imports where feasible #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are way too many GeoNode settings and too much change in them to make it convenient to import them all explicitly, which is why that instance in _prj is left behind (but shouldn't matter a lot anyway because of what _prj is for). flake8 still needs # noqa because of F401 about things being unused, those are impossible to avoid without sacrificing the stated interest of using geonode_apis to expose versions of things which may be adjusted for GeoNode
ghost
deleted the
ghost
mentioned this pull request
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are way too many GeoNode settings and too much change in them to make it
convenient to import them all explicitly, which is why that instance in _prj is
left behind (but shouldn't matter a lot anyway because of what _prj is for).
flake8 still needs # noqa because of F401 about things being unused, those
are impossible to avoid without sacrificing the stated interest of using
geonode_apis to expose versions of things which may be adjusted for GeoNode