Profile screen in SwiftUI

[martindsq]

Closes #681, #976, #977 and #961

[mplorentz]

Going to post some issues I have seen in TestFlight here. Will put them in separate comments as maybe that will help track which ones have been fixed. I'll put checkboxes on them too in case that is helpful? I don't think we get the "Resolve conversation" button unless I comment on a specific line of code.

[mplorentz]

• The ellipsis button is working for me on any posts after I scroll down a bit.

[mplorentz]

• The Read More button has no pressed state.

[mplorentz]

• hashtag detection isn't working for camel case hashtags

[mplorentz]

• The ignored list of people has the title "Blocked". I think it should be "Ignored". (maybe this is a problem in the ASV as well. We can open a separate ticket for this if so)

[mplorentz]

• opening profiles from a search on the discover tab opens the old profile screen

[mplorentz]

• This is more of a design question maybe (CC @Chardot) but I wish the header would collapse down smaller. On my 12 mini I feel like I am losing about ¼ of my screen real estate to the header. Maybe we could hide the following button in the collapsed state and we could shrink the profile picture. Manyverse has a nice animation for the header collapse we could emulate.
  

[martindsq]

• The ellipsis button is working for me on any posts after I scroll down a bit.

I couldn't reproduce this. Can you check if it you still see it in today's build in Testlight? If you still do, let me know.

[mplorentz]

I couldn't reproduce this. Can you check if it you still see it in today's build in Testlight? If you still do, let me know.

Just verifies that I am still seeing it. Here's a video of my exact steps. If you still can't reproduce then I can check out the branch and do some debugging.

RPReplay_Final1668703525.MP4

[martindsq]

Sorry @mplorentz but that's not the build I sent today. Its still processing I think.

[Chardot]

• The Read More button has no pressed state.

@martindsq For the pressed state we can invert the colors of the button in both light and dark mode. Here's a preview:

[Chardot]

• This is more of a design question maybe (CC @Chardot) but I wish the header would collapse down smaller. On my 12 mini I feel like I am losing about ¼ of my screen real estate to the header. Maybe we could hide the following button in the collapsed state and we could shrink the profile picture. Manyverse has a nice animation for the header collapse we could emulate.
  

This is a very good suggestion, @mplorentz . Here's a smaller collapsed version of the profile card:

[Chardot]

@martindsq Here's an animated prorotype for the collapsing of the profile card:

Screen.Recording.2022-11-17.at.18.34.37.mov

[mplorentz]

I think we should probably limit the user's name to one line? Although it would feel bad to truncate people who just have long names. Maybe we need some guidance on how to make long names look good @Chardot?

[mplorentz]

The nav bar is transparent on the latest commit in my 14 pro simulator.

[mplorentz]

@Chardot I think we could use some kind of placeholder for when a user isn't following/followed by/ignoring anyone?

[martindsq]

@mplorentz

I think we should probably limit the user's name to one line? Although it would feel bad to truncate people who just have long names. Maybe we need some guidance on how to make long names look good @Chardot?

I went ahead and made it a two line limit label (because we can), and instead of using the full identity when the name is not available, it now uses the short identifier

The nav bar is transparent on the latest commit in my 14 pro simulator.

Fixed this

@Chardot I think we could use some kind of placeholder for when a user isn't following/followed by/ignoring anyone?

When implementing the profile screen I asked this same question and he preferred to show it as it is.

[Chardot]

@Chardot I think we could use some kind of placeholder for when a user isn't following/followed by/ignoring anyone?

That's a very good suggestion. What about something like this?