Use OSLog package to take advantage of Xcode 15 log formatting #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks nice! However, this increases the minimum supported version to iOS 14 and would make Planetary unable to use this package anymore right? Maybe we can use both os_log and OSLogger to continue supporting iOS 13 |
|
@martindsq Planetary actually requires iOS 16 right now, so no worries there! |
|
I got confused because the minimum version for the project is 13.4, but the target overrides it to 16. We are good to merge this then |
martindsq
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 15 brings some powerful new log filtering features, but you have to use OSLog.Logger to use them. This updates the package to replace os_log with OSLog.Logger and capture the caller's filename so the logs can be associated to the caller's file.