Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rule S1066 #724

Merged
merged 1 commit into from
Dec 14, 2019
Merged

remove rule S1066 #724

merged 1 commit into from
Dec 14, 2019

Conversation

Oaroomy
Copy link
Contributor

@Oaroomy Oaroomy commented Dec 14, 2019

Merged 2 If statement

@claassistantio
Copy link

claassistantio commented Dec 14, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #724 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   86.63%   86.64%   +<.01%     
==========================================
  Files         221      221              
  Lines       18740    18737       -3     
==========================================
- Hits        16235    16234       -1     
  Misses       1346     1346              
+ Partials     1159     1157       -2
Impacted Files Coverage Δ
Libplanet/Store/DefaultStore.cs 85.53% <50%> (-0.08%) ⬇️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 95.86% <0%> (+0.1%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 65.78% <0%> (+0.52%) ⬆️

@longfin
Copy link
Member

longfin commented Dec 14, 2019

@Oaroomy Thanks for your first contribution! 🎉

  • Could you submit our CLA?
  • We're using a changelog checker. but it doesn't seem to need any changelog for these changes because there is no interface change or bug fixing. so you need skip changelog on your commit message to bypass this check.

Copy link
Member

@longfin longfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@earlbread earlbread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@limebell limebell merged commit 86fe5ed into planetarium:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants