Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting peer dependency while trying make up language=python #388

Closed
sardine8042 opened this issue Nov 1, 2022 · 4 comments
Closed

Comments

@sardine8042
Copy link

Hello, I'm following the instructions for the quickstart. After trying make up language=python, I hit this snag:

#0 2.448 npm ERR! Conflicting peer dependency: [email protected]
#0 2.448 npm ERR! node_modules/typescript
#0 2.448 npm ERR!   peerOptional typescript@"^3.2.1" from [email protected]
#0 2.448 npm ERR!   node_modules/react-scripts
#0 2.448 npm ERR!     react-scripts@"4.0.1" from the root project

If it matters, I'm running this on an M1 Mac.

Steps to reproduce:

  • Clone the quickstart
  • run make up language=python

I've tried adding --legacy-peer-deps to line 13 of the frontend Dockerfile, but that runs into more issues. Adding --force seems to bypass the error, but I'm a bit concerned there may cause problems down the line. Is anyone else running into this issue?

@phoenixy1
Copy link
Contributor

Hmm, I wasn't able to reproduce that. Do you get the same issue when using the non-Docker version?

--force shouldn't case any problems down the line.

cc: @lindawoo-plaid

@sardine8042
Copy link
Author

Do you get the same issue when using the non-Docker version?

I suspect it would, although I haven't tested that out. This smells like an M1 issue to me.

--force shouldn't case any problems down the line.

Sounds good, I haven't run into any issues so far either.
Thanks for the input! Feel free to close this one as non-reproducible.

@horatiothomas
Copy link

Can confirm this happens to me when I use docker, but works with the non-Docker version. I'm also on an M1 Mac fwiw.

phoenixy1 added a commit that referenced this issue Nov 3, 2022
Fix npm installation failure issue (issue #388)
@phoenixy1
Copy link
Contributor

This is now fixed! In case you're curious, the factor was the version of npm installed, rather than the Mac chip. Thank you for reporting this issue!

SpencerHHurst pushed a commit to SpencerHHurst/quickstart that referenced this issue Jul 10, 2024
Fix npm installation failure issue (issue plaid#388)
fisherrjd pushed a commit to fisherrjd/quickstart that referenced this issue Oct 12, 2024
Fix npm installation failure issue (issue plaid#388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants