Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.78 #169

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Bump MSRV to 1.78 #169

merged 1 commit into from
Aug 9, 2024

Conversation

popzxc
Copy link
Contributor

@popzxc popzxc commented Aug 9, 2024

Bumps MSRV to 1.79 1.78. Two reasons:

  1. 1.70 is too old, and CI is broken. At least 1.74 is required.
  2. Output of cargo has changed, and it's better for tests to reflect the current state of affairs.

Changes were introduced in 1.78
Also fixes newly added clippy lints.

@pksunkara
Copy link
Owner

Output of cargo has changed, and it's better for tests to reflect the current state of affairs.

Which version is that? I would prefer to set either that or 1.74 as MSRV whichever is higher. Setting 1.79 might break a few people's workflows.

@popzxc popzxc changed the title Bump MSRV to 1.79 Bump MSRV to 1.78 Aug 9, 2024
@popzxc
Copy link
Contributor Author

popzxc commented Aug 9, 2024

Changes were introduced in 1.78 (PR).

Changed the PR accordingly.

@pksunkara pksunkara merged commit 4517c60 into pksunkara:master Aug 9, 2024
7 checks passed
@popzxc popzxc deleted the bump-msrv branch August 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants