[PKP-LIB][stable-3_4_0] #11011 Fix title assignment functionality #11139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jonasraoni
reviewed
Mar 31, 2025
| $newTitles = []; | ||
|
|
||
| // Get the explicitely provided user titles |
There was a problem hiding this comment.
Suggested change
| // Get the explicitely provided user titles | |
| // Get the explicitly provided user titles |
| $newTitles[$locale] = null; | ||
| continue; | ||
| } | ||
|
|
||
| $newTitles[$locale] = $inputTitle; | ||
| // Check if there is a display title for the NMI. If not for this locale, explicitely define one |
There was a problem hiding this comment.
Suggested change
| // Check if there is a display title for the NMI. If not for this locale, explicitely define one | |
| // Check if there is a display title for the NMI and the given locale. If not, explicitly define one |
Comment on lines
+212
to
+220
| if (!isset($originalDisplayTitles[$locale])) { | ||
| $newTitles[$locale] = $trimmedTitle; | ||
| continue; | ||
| } | ||
|
|
||
| // Update title if explicitly defined or changed from default | ||
| if (isset($localizedTitlesFromDB[$locale]) || $originalDisplayTitles[$locale] !== $trimmedTitle) { | ||
| $newTitles[$locale] = $trimmedTitle; | ||
| } |
There was a problem hiding this comment.
I think this can be left as:
Suggested change
| if (!isset($originalDisplayTitles[$locale])) { | |
| $newTitles[$locale] = $trimmedTitle; | |
| continue; | |
| } | |
| // Update title if explicitly defined or changed from default | |
| if (isset($localizedTitlesFromDB[$locale]) || $originalDisplayTitles[$locale] !== $trimmedTitle) { | |
| $newTitles[$locale] = $trimmedTitle; | |
| } | |
| // Update title if explicitly defined or changed from default | |
| if (isset($localizedTitlesFromDB[$locale]) || ($originalDisplayTitles[$locale] ?? null) !== $trimmedTitle) { | |
| $newTitles[$locale] = $trimmedTitle; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.