Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorList to support diacritics in author names #618

Open
wants to merge 3 commits into
base: ojs-dev-2_4
Choose a base branch
from
Open

AuthorList to support diacritics in author names #618

wants to merge 3 commits into from

Conversation

ojsbsb
Copy link

@ojsbsb ojsbsb commented Sep 22, 2015

Added some code to authorIndex.tpl so that author last names that start with diacritics don't trigger unwanted h3 headings. This will be especially interesting to journals with authors coming from non-english countries. I'm writing up a forum post about this and will post the link here.

@asmecher
Copy link
Member

@ojsbsb, thanks for contributing. There are a few ways I'd suggest tinkering with this before it'll be suitable for inclusion as core code:

  • PHP should be moved into the controller code (rather than the template file) as much as possible
  • The grouping used should be language-specific, not hard-coded
    Let me know if I can provide any guidance with this!

@bkroll
Copy link

bkroll commented Sep 22, 2015

This is the forum post I wrote for this PR: http://forum.pkp.sfu.ca/t/handling-of-author-last-names-starting-with-a-diacritic-in-author-list/4225

Thanks for your comments, @asmecher! I will work on that in the next couple of days and then post here again.

oh sorry: @ojsbsb and me are the same person - usually posting from @ojsbsb for OJS stuff...

@bkroll
Copy link

bkroll commented Sep 25, 2015

With the last two commits I have just addressed your second comment, @asmecher, regarding the settings string. The hard-coded version was only for demonstration. The sorter setting can now be read from the currently active localisation or, if there is no such setting for the active locale, the default alphabet is used.

I'd like to move most of the PHP code somewhere else, at least the lines until $settingsArray is created. Could you give me a hint where the appropriate place would be in the OJS structure? Thanks!

@asmecher
Copy link
Member

@bkroll, thanks -- as for moving the PHP out of the template, I'd suggest tinkering with putting it into pages/search/SearchHandler.inc.php in the authors function. You'll see near the bottom of that function that this is where the authorIndex.tpl template you're working with is invoked.

@bkroll
Copy link

bkroll commented Oct 16, 2015

Having played with this a bit, it turns out that all other solutions lead to much more lines of code than this. The solution is based on arrays, and as arrays can't be passed to smarty directly, moving PHP out of the template would lead to larger modifications.

The localization is now implemented by 6c3091c as required.

@bkroll
Copy link

bkroll commented Nov 2, 2015

So, before we forget about this - is there anything else we should do to make this fit in?

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants