Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAIRE plugin 2.4.8 #1383

Open
wants to merge 10 commits into
base: ojs-stable-2_4_8
Choose a base branch
from

Conversation

atarix83
Copy link

Hi,

We proceeded to add some features to OpenAire plugin for OJS 2.4.x.

What we have changed is :

  • add new specific OpenAire metadata like project title, funder and funding program;
  • search for the metadata information space of OpenAIRE through HTTP API;
  • fill automatically edit form

Thanks
Giuseppe

@atarix83 atarix83 changed the title OpenAIRE plugin OpenAIRE plugin 2.4.8 May 15, 2017
@bozana
Copy link
Contributor

bozana commented May 15, 2017

@atarix83, thanks a lot for the contribution! I will take a detailed look, code review and testing. Please be patient, because we have currently so much other things to do with a higher priority, but we will do our best.
Maybe already a comment: I am not 100% sure, but it could be that the copyright dates were correct. I will double check and let you know.
Also, is the deletion of "?>" at the end of the php files intentional?
And finally: could you maybe provide a link to an OpenAIRE documentation, describing the features/requirements you have implemented?

@bozana bozana self-requested a review May 15, 2017 13:48
@atarix83
Copy link
Author

Hi @bozana thank you for your availability.

Also, is the deletion of "?>" at the end of the php files intentional?

Yes It's intentional as a good practice, but if it doesn't follow OJS code styleguide I put them back.

And finally: could you maybe provide a link to an OpenAIRE documentation, describing the features/requirements you have implemented?

There are no specific documentations, but simply we wanted to improve functionalities of the current openAIRE plugin

@asmecher
Copy link
Member

(Just a quick note -- it's fine to remove the closing ?> at the end of scripts. I've been meaning to script up a full removal in the PKP codebases but haven't gotten to it yet.)

@bozana
Copy link
Contributor

bozana commented May 26, 2017

Thanks @asmecher, I thought so...
One more question for you already now: should the copyright information be changed, like proposed in this PR?

@asmecher
Copy link
Member

Updating the dates to 2017 is fine, but the (c) should be to Simon Fraser University, not Simon Fraser University Library. (The Library doesn't exist as a separate legal entity, so the copyright falls to SFU.)

@atarix83
Copy link
Author

I've updated copyright

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants