Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ids for checkboxes on user registration form #249

Closed
kaitlinnewson opened this issue Aug 7, 2024 · 2 comments
Closed

Missing ids for checkboxes on user registration form #249

kaitlinnewson opened this issue Aug 7, 2024 · 2 comments
Assignees

Comments

@kaitlinnewson
Copy link
Member

Describe the bug
The two consent check boxes on the user registration form are missing id attributes, which should be the same as the existing name attributes and the associated label. This means the labels are not properly associated with the inputs, and is an accessibility issue.

This issue is present in the 3.3, 3.4, and main branches.

Additional context

<input type="checkbox" class="form-check-input" name="privacyConsent" value="1"{if $privacyConsent} checked="checked"{/if}>

<input type="checkbox" class="form-check-input" name="emailConsent" value="1"{if $emailConsent} checked="checked"{/if}>

kaitlinnewson added a commit to kaitlinnewson/healthSciences that referenced this issue Aug 7, 2024
@kaitlinnewson
Copy link
Member Author

kaitlinnewson commented Aug 7, 2024

PRs for review:

Not applicable for 3.3 (checkboxes are wrapped inside the label element).

kaitlinnewson added a commit to kaitlinnewson/healthSciences that referenced this issue Aug 7, 2024
asmecher added a commit that referenced this issue Aug 8, 2024
#249 input labels on registration form
asmecher added a commit that referenced this issue Aug 8, 2024
#249 input labels on registration form
@asmecher
Copy link
Member

asmecher commented Aug 8, 2024

Both PRs merged, thanks!

@asmecher asmecher closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants