pkp/pkp-lib#2564 Submission title and sub title with HTML tag handling #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g functionality added
asmecher
reviewed
Feb 7, 2023
filter/ArticleCrossrefXmlFilter.php
Outdated
| @@ -113,8 +113,8 @@ public function createJournalArticleNode($doc, $submission) | |||
|
|
|||
| // title | |||
| $titlesNode = $doc->createElementNS($deployment->getNamespace(), 'titles'); | |||
| $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'title', htmlspecialchars($publication->getLocalizedTitle($locale), ENT_COMPAT, 'UTF-8'))); | |||
| if ($subtitle = $publication->getData('subtitle', $locale)) { | |||
| $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'title', htmlspecialchars($publication->getLocalizedTitle($locale, 'html'), ENT_COMPAT, 'UTF-8'))); | |||
There was a problem hiding this comment.
I think this will lead these fields to be double-escaped. A title containing markup should look like:
<title>E=mc<sup>2</sup></title>
...but the call to htmlspecialchars will cause it to look like...
<title>E=mc<sup>2</sup></title>
There was a problem hiding this comment.
@asmecher htmlspecialchars was there before my changes . Was that a mistake ? Also considering the following title
<title>Albert Einstein great formula "E=MC<sup>2</sup>" allow us to measure the released energy by nuclear fusion</title>
Do we allow quotes(single or double) in title ?
There was a problem hiding this comment.
htmlspecialchars made sense with plaintext content (it will make sure that < > & will be interpreted as text characters, not HTML entities) but now that we're allowing HTML it'll need to be changed for the appropriate filtering function. We do allow quotes in titles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide solution for pkp/pkp-lib#2564