Chunking and CTRL-C handling improvements #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous chunking stream adapter had a problem that if the underlying stream never went into Poll::Pending state, it looped forever. It never yielded back to the executor, the time was not properly advanced, and the chunks were not produced. This commit fixes it by limiting the number of items requested from the underlying stream in a single poll_next, and letting the runtime poll again immediately if there exist items ready to pick. This way we give the async runtime a chance to execute a different future or to do other important stuff.
By moving the SIGTERM logic earlier in the stream pipeline, now when SIGTERM is received, we emit and process the last chunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.