test: add test for shorthand transform #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for opening and closing the PR so many times, it was just the test that was wrong. Now it works correctly, and the shorthands are working 😅 |
bjohansebas
force-pushed
the
add-test
branch
from
4c35b38 to
6b21ccf
Compare
bjohansebas
force-pushed
the
add-test
branch
from
6b21ccf to
635b0bf
Compare
bjohansebas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the shorthands are really not working. I’ve created a simple test that would be good to add to verify this behavior. Maybe someone could create another PR to fix it?This adds tests to verify the behavior of
convert, which transforms the shorthands.