Skip to content

make sure to kill background process if set -m fails #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samueru-sama merged 2 commits into from
Sep 7, 2026
Merged

make sure to kill background process if set -m fails #853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf85e8e
make sure to kill background process if set -m fails
Samueru-sama Sep 7, 2026
c1e050a
address review
Samueru-sama Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions useful-tools/quick-sharun.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,27 @@ _sanity_check() {
done
}

# If set -m fails to work in strace mode it will result in a CI hang
# so recursively look for all childs and kill them
_kill_tree() {
for c in $(cat /proc/"$2"/task/"$2"/children 2>/dev/null); do
_kill_tree "$1" "$c"
done
kill -s "$1" "$2" 2>/dev/null || :
}

_kill_traced() {
if kill -0 -"$1" 2>/dev/null; then
kill -TERM -"$1" 2>/dev/null || :
sleep 1
kill -KILL -"$1" 2>/dev/null || :
else
_kill_tree TERM "$1"
sleep 1
_kill_tree KILL "$1"
fi
}

# do a basic test to make sure at least the application is not totally broken
# like when libraries are missing symbols and similar stuff
_test_appimage() {
Expand Down Expand Up @@ -512,9 +533,7 @@ _test_appimage() {
_echo "------------------------------------------------------------"
_echo "Test went OK."
_echo "------------------------------------------------------------"
kill -TERM -$pid 2>/dev/null || :
sleep 1
kill -KILL -$pid 2>/dev/null || :
_kill_traced $pid
exit 0
else
# process exited before timeout, something went wrong.
Expand Down Expand Up @@ -547,9 +566,7 @@ _simple_test_appimage() {
set +m

sleep 7
kill -TERM -$pid 2>/dev/null || :
sleep 1
kill -KILL -$pid 2>/dev/null || :
_kill_traced $pid

test="$(cat "$log")"
case "$test" in
Expand Down Expand Up @@ -1550,9 +1567,7 @@ _lib4bin_collect_strace() {
set +m

sleep "$STRACE_TIME"
kill -TERM -$pid 2>/dev/null || :
sleep 1
kill -KILL -$pid 2>/dev/null || :
_kill_traced $pid
wait $pid 2>/dev/null || :

out=$(awk '/calling init/{print $NF}' "$dlopened" | sed \
Expand Down