-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework client to prevent after-Close usage, and support perm at Open #574
Merged
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d1903fb
rework client to prevent after-close usage, and support perm at open
puellanivis f3501dc
address code review
puellanivis e21cd94
move setting times to the last operation so chown doesn't have a chan…
puellanivis 3df3035
new race condition warning, yay
puellanivis 4cd7ff4
testing an idea
puellanivis 6c7c0da
remove warnings about aberrent race detection, I think it was real
puellanivis e808920
remove unnecessary block, and explain why the one added is necessary
puellanivis ba3d6ab
explain mechanics of use-after-close protection
puellanivis 72aa403
more short-circuits
puellanivis 3ce4d4e
one more race-condition causing return
puellanivis 5d66cde
better cascading
puellanivis 159d286
populate Attrs in requestFromPacket
puellanivis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was located in a different file, which is a little weird, since it operates on
FileStat
.