request-server: don't return EOF if there is an unexpected error #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
requested changes
Nov 5, 2020
Done, thank you |
io.EOF means no error so convert to ErrUnexpectedEOF if we detect a transfer error
drakkan
added a commit
to drakkan/sftpgo
that referenced
this pull request
Nov 16, 2020
Include this patch: pkg/sftp#393 to avoid request accumulation (no underlying fd) if we return an error. Before this patch the accumulated requests are released only when the client disconnects. We use our fork for now to include pkg/sftp#392 too
puellanivis
reviewed
Nov 17, 2020
This way even if we do not read from this channel, there is not a blocked goroutine left hanging
puellanivis
approved these changes
Nov 18, 2020
Thank you! |
drakkan
added a commit
to drakkan/sftpgo
that referenced
this pull request
Nov 18, 2020
These patches are now merged upstream: pkg/sftp#392 pkg/sftp#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.EOF means no error so convert to ErrUnexpectedEOF if we detect a transfer error