Export RealPath for potential client use #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned I went through the path handling code. It’s all generally server-side stuff. Nothing necessary to be done on the client side. The standard even says this request packet can be called with essentially any arbitrary path. |
This was referenced Mar 6, 2021
Closed
|
Great! I suggest to add a comment to avoid warnings like this one |
|
server side the method just calls cleanPacketPath so specific test cases should not be needed |
|
Feel free to merge, and then cut a release at your leisure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real simple, it’s exactly what the title says, nothing more.