Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method "RealPath" is needed for sftp.Client #399

Closed
ltmit opened this issue Dec 5, 2020 · 4 comments
Closed

method "RealPath" is needed for sftp.Client #399

ltmit opened this issue Dec 5, 2020 · 4 comments

Comments

@ltmit
Copy link

ltmit commented Dec 5, 2020

We can see that Client.Getwd() uses a hidden method "realpath" to make path translation.
This method is useful for many situations, but there is no other public method to provide the same functionality.
So I suggest to make the function public.

@drakkan
Copy link
Collaborator

drakkan commented Feb 10, 2021

I'm not very fluent on client side, @puellanivis what do you think about? Thank you

@puellanivis
Copy link
Collaborator

It seems like it’s a genuine request packet, and as noted could have some utility for clients. I don’t really see any reason not to expose it.

However, this comes with a caveat. I’m not sure we’re handling all the Host/Client OS situations properly. It should probably have a good and thorough check up before just exporting the functionality.

@puellanivis
Copy link
Collaborator

#410

@drakkan drakkan closed this as completed Mar 6, 2021
@drakkan
Copy link
Collaborator

drakkan commented Mar 6, 2021

This is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants