Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift-C++ binding & swift pjsua2 sample app #2723

Merged
merged 8 commits into from
Jun 11, 2021

Conversation

emretufekci
Copy link
Contributor

@emretufekci emretufekci commented Jun 2, 2021

Swift & C++ Bindings & Sample App for 64 bit Simulator (PJSua2 Level)

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2021

CLA assistant check
All committers have signed the CLA.

@emretufekci emretufekci changed the title sample app added swift-C++ binding & swift pjsua2 sample app Jun 2, 2021
@sauwming
Copy link
Member

sauwming commented Jun 3, 2021

Thank you very much for providing an iOS Swift sample app using pjsua2.

I tested it here and I had to fix a few things to make it run (such as by defining PJ_AUTOCONF=1), but after that, it can successfully run without any issue on arm64, so I'm not sure why you have to limit your target to the simulator.

Also, the registration login and call destination are still hard coded, so you may need to remove it.

@emretufekci
Copy link
Contributor Author

emretufekci commented Jun 3, 2021

Thank you very much for providing an iOS Swift sample app using pjsua2.

I tested it here and I had to fix a few things to make it run (such as by defining PJ_AUTOCONF=1), but after that, it can successfully run without any issue on arm64, so I'm not sure why you have to limit your target to the simulator.

Also, the registration login and call destination are still hard coded, so you may need to remove it.

Hardcoded parts removed, i forgot to remove it 👍
I tried to add PJ_AUTOCONF=1 but couldn't run via that config, that's why pushed it as is. Looking for it. If you have already, could you share it?

@sauwming
Copy link
Member

sauwming commented Jun 4, 2021

Here's the modification of the pbxproj file that I use:
pbxproj_diff.txt

@emretufekci
Copy link
Contributor Author

Thank you! worked like a charm 👍

Pushed latest changes as well.

@emretufekci emretufekci force-pushed the swift-pjsua2-sample-app branch from 96a1834 to f40dc3c Compare June 4, 2021 08:25
@sauwming
Copy link
Member

sauwming commented Jun 4, 2021

  • Can you please move the directory to a new one pjsip-apps/src/pjsua2/ios-swift (the app name can remain the same) instead of pjsip-apps/src/samples? This is because samples directory are meant for simple samples only that consist of a single file or dummy samples (in the case of Android).

  • For the source files *.swift, *.h/hpp, *.cpp, *.mm, we'd like to ask your permission if you're okay if we change the copyright info to look like https://github.com/pjsip/pjproject/blob/master/pjmedia/src/pjmedia-codec/silk.c . If you agree, you can change this yourself, or we can change it for you after merging later, that's up to you.

@emretufekci
Copy link
Contributor Author

emretufekci commented Jun 4, 2021

Sure, no problem at all i added copyright message.

I created pjsua2 directory same level with pjsua folder and moved sample app to there. But i am not sure is it proper way for you?

@sauwming
Copy link
Member

sauwming commented Jun 4, 2021

The part "Contributed by", that's where you can put your name :)
Or you can remove it if you prefer to remain anonymous.

@emretufekci emretufekci force-pushed the swift-pjsua2-sample-app branch from 39c2cf8 to 413142a Compare June 4, 2021 10:55
@emretufekci
Copy link
Contributor Author

I missed the part now added it :)
I guess finally it's okay

.gitignore Outdated Show resolved Hide resolved
pjsip-apps/build/Makefile Outdated Show resolved Hide resolved
pjsip-apps/build/Makefile Outdated Show resolved Hide resolved
@emretufekci
Copy link
Contributor Author

Solved with e77c002 👍

@emretufekci emretufekci force-pushed the swift-pjsua2-sample-app branch from 589097f to 0d4d41e Compare June 9, 2021 12:43
@sauwming sauwming merged commit 11316a3 into pjsip:master Jun 11, 2021
@emretufekci emretufekci deleted the swift-pjsua2-sample-app branch June 11, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants