Convert Filter resolution from property to accessor #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShukantPal
requested changes
Sep 7, 2021
Co-authored-by: Shukant Pal <[email protected]>
ShukantPal
approved these changes
Sep 7, 2021
bigtimebuddy
approved these changes
Sep 8, 2021
ShukantPal
added
the
✅ Ready To Merge
GoodBoyDigital
approved these changes
Sep 13, 2021
|
Thank you @mcdenhoed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR is an attempt to fix this issue that I've had with the PIXI Advanced Blur Filter (documented here: pixijs/filters#301). I describe the issue in detail there, but here's a short summary:
Filterhas a public property namedresolution.AdvancedBloomFilteroverrides this property with an accessor namedresolution.AdvancedBloomFiltermaintains a private_resolutionproperty which is set by this accessor (along with some other side-effects, which seems to be the whole purpose of using an accessor instead of a property).However, as of microsoft/TypeScript#37894,
tscnow treats overriding a property with an accessor as an error.This PR converts the definition of
resolutionin the baseFilterclass to an accessor to avoid this error.Pre-Merge Checklist
npm run lint)npm run test)