Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9250 Refactor ModActionItem remove unnecessary props #9254

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Oct 9, 2024

What does this PR do?

disabled={!isDirty}
/>
)}
{/* TODO: did we really want to always show SaveButton? That is the current behavior as of 2.1.5-beta.1 */}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we? I noticed that the disabled save button might look a little awkward, but maybe that's just me

Screenshot 2024-10-08 at 6 28 11 PM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually sooner expect the ellipsis menu to always show, rather than the save button

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (8318d74) to head (77ef0e4).
Report is 351 commits behind head on main.

Files with missing lines Patch % Lines
src/pageEditor/modListingPanel/ModActionMenu.tsx 70.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9254      +/-   ##
==========================================
+ Coverage   74.24%   75.10%   +0.85%     
==========================================
  Files        1332     1370      +38     
  Lines       40817    42298    +1481     
  Branches     7634     7885     +251     
==========================================
+ Hits        30306    31767    +1461     
- Misses      10511    10531      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 9, 2024

Playwright test results

passed  136 passed
flaky  2 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  142 tests across 46 suites
duration  12 minutes, 54 seconds
commit  77ef0e4
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant