-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9250 Refactor ModActionItem remove unnecessary props #9254
base: main
Are you sure you want to change the base?
Conversation
disabled={!isDirty} | ||
/> | ||
)} | ||
{/* TODO: did we really want to always show SaveButton? That is the current behavior as of 2.1.5-beta.1 */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually sooner expect the ellipsis menu to always show, rather than the save button
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9254 +/- ##
==========================================
+ Coverage 74.24% 75.10% +0.85%
==========================================
Files 1332 1370 +38
Lines 40817 42298 +1481
Branches 7634 7885 +251
==========================================
+ Hits 30306 31767 +1461
- Misses 10511 10531 +20 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
What does this PR do?