-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9227 Refactor useTheme
to use useManagedStorageState
#9228
Open
mnholtz
wants to merge
21
commits into
main
Choose a base branch
from
feature/9227_refactor_use_theme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−79
Open
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0ee3c37
add hideSidebarLogo to manatgedStorageSchema
mnholtz 2bcc02e
override showSidebarLogo in useTheme
mnholtz 5d60f92
add unit tests to useTheme
mnholtz d3db8e9
Merge branch 'main' into feature/9222_hide_sidebar_logo_policy
mnholtz 7b1e90e
fix header button alignment when missing sidebar logo
mnholtz 319fdb6
Merge branch 'feature/9222_hide_sidebar_logo_policy' of https://githu…
mnholtz afa7f80
refactor rename hideSidebarLogo -> showSidebarLogo
mnholtz 58f65a8
refactor combine test cases
mnholtz 3924d4d
add add custom theme to test cases
mnholtz ebba63f
deck version number in code comment
mnholtz 4cba229
Merge branch 'main' into feature/9222_hide_sidebar_logo_policy
mnholtz 1370d6a
refactor use useManagedStorageState instead of readManagedStorageByKey
mnholtz cb2355f
make test cases complete
mnholtz bcc470c
refactor use useManagedStorageState instead of readManagedStorageByKey
mnholtz 29b5180
rebase fixes
mnholtz 2fabe25
resolve merge conflicts
mnholtz 0b71176
resolve merge issues
mnholtz 9c46ed1
replace useManagedStorageState implementation with useAsyncExternalStore
mnholtz ce8a6ac
make some test accomodations for hook changes
mnholtz 4ea0d9b
Merge branch 'refs/heads/main' into feature/9227_refactor_use_theme
mnholtz b584c2a
fix one useManagedStorageState unit test
mnholtz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use this as an opportunity to properly refactor
useManagedStorageState
to returnAsyncState
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use the following? I don't remember if there's a reason why we didn't use that other than that maybe the useAsyncExternalStore method didn't exist yet (I haven't checked) / or it just wasn't very valuable given that managed storage values should never change in practice:
useAsyncExternalStore
readManagedStorage
I think we then get error handling for free with those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering the same thing, re why not use readManagedStorage + useAsyncExternalStore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason not to. The main difference will be it will be technically possible for the hook to return an error state. Whereas the current one could potentially stay
isLoading
indefinitely. But I don't think the difference matters in practice