Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict null checks exclude 4 #8430

Merged
merged 55 commits into from
May 10, 2024
Merged

Strict null checks exclude 4 #8430

merged 55 commits into from
May 10, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

  • More strict null check fixes

Checklist

  • Designate a primary reviewer @BLoe

@grahamlangford grahamlangford requested a review from BLoe May 9, 2024 17:43
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.41%. Comparing base (6d95047) to head (9503907).
Report is 36 commits behind head on main.

Files Patch % Lines
src/pageScript/pageScript.ts 0.00% 5 Missing ⚠️
src/tinyPages/frame.ts 0.00% 2 Missing ⚠️
...r/tabs/editTab/editorNodes/brickNode/BrickNode.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8430      +/-   ##
==========================================
- Coverage   73.47%   73.41%   -0.07%     
==========================================
  Files        1334     1352      +18     
  Lines       41259    41521     +262     
  Branches     7686     7777      +91     
==========================================
+ Hits        30316    30483     +167     
- Misses      10943    11038      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 9, 2024

Playwright test results - MV2

passed  37 passed
flaky  5 flaky
skipped  8 skipped

Details

report  Open report ↗︎
stats  50 tests across 18 suites
duration  11 minutes, 28 seconds
commit  9503907

Flaky tests

edgeSetup › auth.setup.ts › authenticate
chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database
chrome › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod
edge › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Copy link

github-actions bot commented May 9, 2024

Playwright test results - MV3

passed  48 passed
flaky  2 flaky

Details

report  Open report ↗︎
stats  50 tests across 18 suites
duration  14 minutes, 42 seconds
commit  9503907

Flaky tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@grahamlangford grahamlangford merged commit 6f08e0b into main May 10, 2024
22 checks passed
@grahamlangford grahamlangford deleted the strictNullChecks-exclude-4 branch May 10, 2024 13:34
@grahamlangford grahamlangford added this to the 1.8.14 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants