Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5530: IDB ErrorBoundary in Extension Console to recover from IDB errors #5600

Merged
merged 5 commits into from
Apr 23, 2023

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Apr 23, 2023

What does this PR do?

Demo

  • See Storybook

Checklist

  • Add tests: add via Storybook Storyshots
  • Designate a primary reviewer: @BLoe

@twschiller twschiller changed the title #5530: IDB error boundary in Extension Console #5530: IDB ErrorBoundary in Extension Console to recover from IDB errors Apr 23, 2023
@twschiller twschiller self-assigned this Apr 23, 2023
@twschiller twschiller added this to the 1.7.24 milestone Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #5600 (1c69fe6) into main (c1a6c83) will increase coverage by 0.02%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##             main    #5600      +/-   ##
==========================================
+ Coverage   64.45%   64.47%   +0.02%     
==========================================
  Files        1030     1031       +1     
  Lines       32318    32407      +89     
  Branches     6146     6150       +4     
==========================================
+ Hits        20830    20894      +64     
- Misses      11488    11513      +25     
Impacted Files Coverage Δ
src/extensionConsole/App.tsx 0.00% <ø> (ø)
...xtensionConsole/pages/settings/StorageSettings.tsx 0.00% <0.00%> (ø)
src/telemetry/logging.ts 0.00% <0.00%> (ø)
src/background/telemetry.ts 50.51% <37.93%> (-8.39%) ⬇️
...rc/extensionConsole/components/IDBErrorDisplay.tsx 69.81% <69.81%> (ø)
src/components/ErrorBoundary.tsx 80.00% <72.72%> (+23.47%) ⬆️
src/utils/idbUtils.ts 66.66% <100.00%> (+41.66%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@twschiller twschiller merged commit 75bb247 into main Apr 23, 2023
@twschiller twschiller deleted the feature/5530-idb-error-boundary branch April 23, 2023 18:50
twschiller added a commit that referenced this pull request Apr 23, 2023
twschiller added a commit that referenced this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors opening IndexedDB (IDB)
2 participants