#1869: Dispatch non-jQuery events in @pixiebrix/dom/trigger-event
#1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Nov 13, 2021
| // Trigger a proper MouseEvent on the most common event | ||
| element.click(); | ||
| } else { | ||
| element.dispatchEvent(new Event(event, { bubbles: true })); |
There was a problem hiding this comment.
The event that the listener is the exact object created here, while ideally we should dispatch MouseEvent for mouse events, etc.
I took a shortcut here for click instead of mapping all of the events, but let me know if I should do that instead, I'd probably have to parse the DOM events spec to get a full-ish list
There was a problem hiding this comment.
This is good for now. I've created #1884 for follow up
twschiller
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apage elements #1869