Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to read large IndexedDB value error #9211

Closed
twschiller opened this issue Sep 27, 2024 · 2 comments
Closed

Failed to read large IndexedDB value error #9211

twschiller opened this issue Sep 27, 2024 · 2 comments
Assignees
@grahamlangford
Labels
bug Something isn't working customer Required for a customer projct runtime triage

Comments

@twschiller
Copy link
Contributor

twschiller commented Sep 27, 2024 •
edited
Loading

Describe the bug

Discussion

  • I'm not sure user-facing impact. But this error showed up frequently for a user who has seen the IndexedDB unresponsive banner: https://mixpanel.com/project/2202701/view/143273/app/insights/#report/63816248
  • For triaging, one improvement we might want to make for IndexedDB errors is report which DB/table encountered the problem. E.g., the log DB being corrupted is less of a problem than the local package registry

Resources

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Extension Version: CWS version, at least 2.1.1 and 2.1.2
@twschiller twschiller added bug Something isn't working runtime customer Required for a customer projct triage labels Sep 27, 2024
@grahamlangford
Copy link
Collaborator

For triaging, one improvement we might want to make for IndexedDB errors is report which DB/table encountered the problem. E.g., the log DB being corrupted is less of a problem than the local package registry

Great callout, I will definitely implement that

@grahamlangford
Copy link
Collaborator

This error is being reported by reportError which is not supposed to happen anymore. I'll have to trace the callstack and find out why

This was referenced Oct 3, 2024
Merged
Merged
Merged
grahamlangford added a commit that referenced this issue Oct 4, 2024
@grahamlangford @fungairino
#9211 Retry on failed to read large indexeddb value (#9229)
3ba3f57 
* make operationName part of a config object

* implement first retry

* fix errors from type change

* update error messaging; add handling

* move shouldRetry to the callsites

* document isIDBLargeValueError

* improve comment

* handle retry in test

* remove retry flag and depend on shouldRetry instead

* clear db on large value error

* adds requested comments

---------

Co-authored-by: Eduardo <[email protected]>
grahamlangford added a commit that referenced this issue Oct 8, 2024
@grahamlangford @fungairino
#9211 Retry on failed to read large indexeddb value (#9229)
b0a3994 
* make operationName part of a config object

* implement first retry

* fix errors from type change

* update error messaging; add handling

* move shouldRetry to the callsites

* document isIDBLargeValueError

* improve comment

* handle retry in test

* remove retry flag and depend on shouldRetry instead

* clear db on large value error

* adds requested comments

---------

Co-authored-by: Eduardo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grahamlangford grahamlangford

Labels
bug Something isn't working customer Required for a customer projct runtime triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twschiller @grahamlangford