New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check index before remove, check bbox exists in non-updating methods #28

Merged

davidfig merged 1 commit into pixi-viewport:master from maxakuru:master

Feb 5, 2022

Contributor

maxakuru commented Jan 25, 2022

hey @davidfig - thanks for the lib!

this has a couple minor changes to Simple:

avoid splicing from the end of arrays when item doesn't exist
check object.AABB exists in queries, since it doesn't update the bbox.. I figure if it doesn't have it yet, it wouldn't be considered "visible"


          check index before remove, check bbox exists in non-updating methods

f4f171e

davidfig merged commit 09d1fb6 into pixi-viewport:master

Collaborator

davidfig commented Feb 5, 2022

Thanks! Published on npm as 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet