Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump index.html content for local builds #340

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

jekader
Copy link
Contributor

@jekader jekader commented Jan 5, 2024

When building locally, webui.py is not run so the resulting firmware contains outdated JS artifacts.

Bumping the version based on what the release PixelIt 2.5.0 firmware is serving as index.html

As a future improvement one of the following approaches can be used to ensure local builds get the correct index.html:

  • add a github action to the WebUI repo which would create a PR similar to this one on each successful build. See here for an example.
  • make webui.py run during each build stage and fetch a fresh index.html each time
  • change index.html to fetch a fresh version from upstream and replace content (may be unsafe due to upgrading WebUI without upgrading the firmware)

@foorschtbar
Copy link
Member

We already build a new "index.html" on each build, but use it only in the artefacts and dont repush it to the repo. Maybe a warning in the UI, that this is an outdated or static version or simething will helps? for testing a "old" ui is fine for me and when i change something on the UI, i use the UI Repo with the dev server.

@foorschtbar foorschtbar merged commit 4bb6528 into pixelit-project:develop Jan 11, 2024
1 check passed
@jekader jekader deleted the bump-webinterface branch January 11, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants