temporary fix for post meta attributes bug in Gutenberg 6.6.0 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razwan
changed the title
|
Also, in the fallback version, I enabled the position indicators by default, and will display the scroll indicator if the hero block is the first block in the content and it is set to full height. I guess we're good to go. |
…ade/nova-blocks into meta-attributes-temp-fix
This reverts commit 71c12fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 6.6.0 update seems to cause an issue where the editor breaks when blocks that use post meta as source for one of their attributes are added to the content. see WordPress/gutenberg#17767
This is a temporary solution to avoid crashing the editor by relying on the
NOVABLOCKS_USE_POST_META_ATTRIBUTESconstant to display just a height setting for each hero block instead of using page-level controls that rely on post meta