Unused imports cleanup (#951)

pivovarit · Sep 16, 2024 · 8c7f502 · 8c7f502
1 parent 0ac103c
commit 8c7f502
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 17 deletions.
diff --git a/LICENSE.md b/LICENSE.md
@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright [2020] [Grzegorz Piwowarek]
+   Copyright [2024] [Grzegorz Piwowarek]
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

diff --git a/README.md b/README.md
@@ -171,7 +171,7 @@ Stream API is a great tool for collection processing, especially if you need to
 
 **However, Parallel Streams execute tasks on a shared `ForkJoinPool` instance**.
 
-Unfortunately, it's not the best choice for running blocking operations even when using `ManagedBlocker` - [as explained here by Tagir Valeev](https://stackoverflow.com/a/37518272/2229438)) - this could easily lead to the saturation of the common pool, and to a performance degradation of everything that uses it.
+Unfortunately, it's not the best choice for running blocking operations even when using `ManagedBlocker` - [as explained here by Tagir Valeev](https://stackoverflow.com/a/37518272/2229438) - this could easily lead to the saturation of the common pool, and to a performance degradation of everything that uses it.
 
 For example:
 

diff --git a/src/main/java/com/pivovarit/collectors/Dispatcher.java b/src/main/java/com/pivovarit/collectors/Dispatcher.java
@@ -9,7 +9,6 @@
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.RejectedExecutionException;
 import java.util.concurrent.Semaphore;
-import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Function;
 import java.util.function.Supplier;
@@ -85,17 +84,15 @@ void start() {
                         }
                         Runnable task;
                         if ((task = workingQueue.take()) != POISON_PILL) {
-                            retry(() -> {
-                                executor.execute(() -> {
-                                    try {
-                                        task.run();
-                                    } finally {
-                                        if (limiter != null) {
-                                            limiter.release();
-                                        }
+                            retry(() -> executor.execute(() -> {
+                                try {
+                                    task.run();
+                                } finally {
+                                    if (limiter != null) {
+                                        limiter.release();
                                     }
-                                });
-                            });
+                                }
+                            }));
                         } else {
                             break;
                         }

diff --git a/src/test/java/com/pivovarit/collectors/CompletionOrderSpliteratorTest.java b/src/test/java/com/pivovarit/collectors/CompletionOrderSpliteratorTest.java
@@ -92,7 +92,7 @@ void shouldNotConsumeOnEmpty() {
     @Test
     void shouldRestoreInterrupt() {
         Thread executorThread = new Thread(() -> {
-            Spliterator<Integer> spliterator = new CompletionOrderSpliterator<>(Arrays.asList(new CompletableFuture<>()));
+            Spliterator<Integer> spliterator = new CompletionOrderSpliterator<>(List.of(new CompletableFuture<>()));
             try {
                 spliterator.tryAdvance(i -> {});
             } catch (Exception e) {

diff --git a/src/test/java/com/pivovarit/collectors/FutureCollectorsTest.java b/src/test/java/com/pivovarit/collectors/FutureCollectorsTest.java
@@ -7,7 +7,6 @@
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionException;
-import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.stream.IntStream;
 

diff --git a/src/test/java/com/pivovarit/collectors/test/BasicProcessingTest.java b/src/test/java/com/pivovarit/collectors/test/BasicProcessingTest.java
@@ -57,7 +57,7 @@ Stream<DynamicTest> shouldStartProcessingImmediately() {
               var counter = new AtomicInteger();
 
               Thread.startVirtualThread(() -> {
-                  Stream.iterate(0, i -> i + 1)
+                  var ignored = Stream.iterate(0, i -> i + 1)
                     .limit(100)
                     .collect(c.factory().collector(i -> returnWithDelay(counter.incrementAndGet(), ofSeconds(1))));
               });

diff --git a/src/test/java/com/pivovarit/collectors/test/BatchingTest.java b/src/test/java/com/pivovarit/collectors/test/BatchingTest.java
@@ -31,7 +31,7 @@ Stream<DynamicTest> shouldProcessOnExactlyNThreads() {
               var threads = new ConcurrentSkipListSet<>();
               var parallelism = 4;
 
-              Stream.generate(() -> 42)
+              var ignored = Stream.generate(() -> 42)
                 .limit(100)
                 .collect(c.factory().collector(i -> {
                     threads.add(Thread.currentThread().getName());