Replace Dispatcher's internal ExecutorService with an inline virtual …

…thread
pivovarit · May 1, 2024 · 5deafc6 · 5deafc6
1 parent 58b17c3
commit 5deafc6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/main/java/com/pivovarit/collectors/Dispatcher.java b/src/main/java/com/pivovarit/collectors/Dispatcher.java
@@ -21,10 +21,8 @@ final class Dispatcher<T> {
     private static final Runnable POISON_PILL = () -> System.out.println("Why so serious?");
 
     private final CompletableFuture<Void> completionSignaller = new CompletableFuture<>();
-
     private final BlockingQueue<Runnable> workingQueue = new LinkedBlockingQueue<>();
 
-    private final ExecutorService dispatcher = Executors.newVirtualThreadPerTaskExecutor();
     private final Executor executor;
     private final Semaphore limiter;
 
@@ -53,7 +51,7 @@ static <T> Dispatcher<T> virtual() {
 
     void start() {
         if (!started.getAndSet(true)) {
-            dispatcher.execute(() -> {
+            Thread.ofVirtual().start(() -> {
                 try {
                     while (true) {
                         try {
@@ -90,8 +88,6 @@ void stop() {
             workingQueue.put(POISON_PILL);
         } catch (InterruptedException e) {
             completionSignaller.completeExceptionally(e);
-        } finally {
-            dispatcher.shutdown();
         }
     }
 

diff --git a/src/main/java/com/pivovarit/collectors/FutureCollectors.java b/src/main/java/com/pivovarit/collectors/FutureCollectors.java
@@ -19,7 +19,7 @@ final class FutureCollectors {
                 .collect(collector));
 
             for (var f : list) {
-                f.whenComplete((t, throwable) -> {
+                f.whenComplete((__, throwable) -> {
                     if (throwable != null) {
                         future.completeExceptionally(throwable);
                     }