Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Conversation

@suquark
Copy link
Contributor

@suquark suquark commented Jan 2, 2020

No description provided.

@suquark
Copy link
Contributor Author

suquark commented Jan 2, 2020

The tests have all passed, except 2 issues:

  • We got ValueError: must use protocol 4 or greater to copy this object; since __getnewargs_ex__ returned keyword arguments., which seems to be a 'correct' behavior under python3.5
  • Numpy refused to support python3.5, but it can be simply changed by modifying the line checking the python version.

@robertnishihara
Copy link

Would it make sense to add 3.5 to Travis?

@pcmoritz
Copy link

@suquark Can you fix the travis tests and add tests for python 3.5 so we can get this merged?

@suquark
Copy link
Contributor Author

suquark commented May 17, 2020

The Arm64 errors seem not related.

@pcmoritz
Copy link

pcmoritz commented May 18, 2020

@pitrou Can you take a look at this and see if we can get the PR merged? It would be great to do that and prepare a new release of pickle5-backport! Let me know if we can help with anything on this front!

@suquark Says the error on ARM is unrelated to this PR and already happens on the current master of this repo (due to a new numpy release that breaks it).

@pitrou
Copy link
Owner

pitrou commented May 18, 2020

Could you split Python 3.5 support into a separate PR?

@suquark
Copy link
Contributor Author

suquark commented May 18, 2020

@pitrou Sure. Let me make one that only contains the Python3.5 support. BTW, will you also add the bpo-39492 fix (or just sync up with the latest cpython pickle)? This is also critical I think. Otherwise I would also create another PR to fix the reference count issue.

@pitrou
Copy link
Owner

pitrou commented May 18, 2020

I think syncing would be best, is that something you want to try to do?

@suquark
Copy link
Contributor Author

suquark commented May 18, 2020

Yes, so I will create two PRs, one for the syncing, one for the python3.5 support (based on the synced version)

@suquark
Copy link
Contributor Author

suquark commented May 19, 2020

This PR has been divided into #15 and #16.

@suquark suquark closed this May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants