enable lint correctness rules

app.js

@@ -44,7 +44,7 @@ app.set('view engine', 'jade');
 app.use(logger('dev'));
 app.use(cookieParser());
 app.use(cachify);
-app.use((req, res, next) => {
+app.use((_req, res, next) => {
   cachify.helpers().then(fns => {
     res.locals.cachify = fns.cachify;
     next();

biome.json

@@ -30,6 +30,9 @@
     "enabled": true,
     "rules": {
       "recommended": true,
+      "correctness": {
+        "all": true
+      },
       "complexity": {
         "noForEach": "off",
         "useLiteralKeys": "off"
@@ -44,5 +47,24 @@
         "noAssignInExpressions": "off"
       }
     }
-  }
+  },
+  "overrides": [
+    {
+      "include": [
+        "**/sw.template.js"
+      ],
+      "linter": {
+        "rules": {
+          "correctness": {
+            "noUndeclaredVariables": "off"
+          }
+        }
+      },
+      "javascript": {
+        "globals": [
+          "options"
+        ]
+      }
+    }
+  ]
 }

lib/cli/fetch.js

@@ -10,7 +10,7 @@ function fetchExample(resortId) {
     resort = require(`../resorts/${resortId}/resort.json`);
     curl(resort.dataUrl || resort.api || resort.url, resortId);
     done = true;
-  } catch (e) {
+  } catch {
     console.error(resortId, 'is not a valid resort ID');
     process.exit(1);
   }

lib/cli/generate.js

@@ -114,7 +114,7 @@ function write(dst, json) {
 
 function copy(src, dst, params) {
   console.log('Generating %s...', dst);
-  fs.readFile(src, 'utf8', (err, data) => {
+  fs.readFile(src, 'utf8', (_err, data) => {
     data = template(data)(params);
     fs.writeFileSync(dst, data);
   });

lib/cli/noaa.js

@@ -61,7 +61,7 @@ function writeDescriptor(resortId, descriptor) {
 function readDescriptor(resortId) {
   try {
     return require(`../resorts/${resortId}/resort.json`);
-  } catch (e) {
+  } catch {
     console.error(resortId, 'is not a valid resort ID');
     process.exit(1);
   }

lib/lifts/index.js

@@ -48,7 +48,7 @@ function fetch(resort, fn) {
   }
   debug("Fetch lift status for %s", resort.id);
   const rfau = resort._rfau;
-  rfau.fn(rfau.url, resort._parseFn, (err, data) => {
+  rfau.fn(rfau.url, resort._parseFn, (_err, data) => {
     Promise.resolve(data).then((data, err) => {
       if (err || !data) {
         data = {};

lib/loaders.js

@@ -23,7 +23,7 @@ function appendResorts(data, resorts) {
 
 function load(fn) {
   debug('Loading resorts...');
-  async.parallel(loaders, (err, results) => {
+  async.parallel(loaders, (_err, results) => {
     const data = results.reduce(appendResorts, Object.create(null));
     debug('Loaded %d resorts.', Object.keys(data).length);
     fn(null, data);

lib/routes/data.js

@@ -155,7 +155,7 @@ function data() {
 
   function init(fn) {
     // all loaders
-    loaders.load((err, data) => {
+    loaders.load((_err, data) => {
       initCache(data);
       my.tags = tags(data);
       my.all = Object.keys(cache);

lib/routes/headers.js

@@ -34,7 +34,7 @@ const reportTo = JSON.stringify({
   ]
 });
 
-function csp(req, res, next) {
+function csp(_req, res, next) {
   const cspNonce = crypto.randomBytes(16).toString('base64');
   res.locals.cspNonce = cspNonce;
   res.header(CSP_HEADER_NAME, cspPolicy.replace('$random', cspNonce));
@@ -44,18 +44,18 @@ function csp(req, res, next) {
   next();
 }
 
-function referrer(req, res, next) {
+function referrer(_req, res, next) {
   res.header('Referrer-Policy', 'no-referrer-when-downgrade');
   next();
 }
 
-function feature(req, res, next) {
+function feature(_req, res, next) {
   res.header('Feature-Policy', `fullscreen 'self'`);
   next();
 }
 
 
-function link(req, res, next) {
+function link(_req, res, next) {
   const preloadLinks = [{
       path: '/stylesheets/fonts/lift-status.woff2',
       as: 'font',

lib/routes/index.js

@@ -50,7 +50,7 @@ function renderResorts(req, res, next) {
  *   /resort/<name> - display a specific resort
  *   /?resorts=<name1>,<name2>... - display resorts on the list
  */
-function index(req, res, next) {
+function index(req, _res, next) {
   req.requested = req.params.resort || req.query.resorts;
   req.opts = {
     openSingle: true
@@ -92,7 +92,7 @@ function tag(req, res, next) {
   next();
 }
 
-function about(req, res) {
+function about(_req, res) {
   res.render('about', {
     title: title('About')
   });
@@ -162,7 +162,7 @@ function meta(req, res, next) {
 
 function routes(app) {
 
-  function reqData(req, res, next) {
+  function reqData(req, _res, next) {
     req.data = app.data;
     next();
   }

lib/routes/service-worker.js

@@ -11,7 +11,7 @@ const {
 
 const DEBUG = NODE_ENV !== 'production';
 
-function renderServiceWorker(req, res) {
+function renderServiceWorker(_req, res) {
   createServiceWorkerScript(res.locals).then(serviceWorkerScript => {
     // do not cache service worker
     res.header('Cache-Control', 'no-cache, max-age=0, must-revalidate');

test/lifts/index.js

@@ -13,7 +13,7 @@ function testResort(name, ext, expected, opts = {}) {
   const parse = makeParse(name);
 
 
-  function testHTML(t, done) {
+  function testHTML(_t, done) {
     const stream = createReadStream(filename);
 
     stream.on('error', done);
@@ -24,7 +24,7 @@ function testResort(name, ext, expected, opts = {}) {
     }));
   }
 
-  function testJSON(t, done) {
+  function testJSON(_t, done) {
     const asyncParse = parse.isAsync ?
       parse :
       (data, fn) => process.nextTick(fn, null, parse(data));

test/opening.js

@@ -14,14 +14,14 @@ const today = iso(now);
 const future = iso(now + 2 * day);
 const past = iso(now - 2 * day);
 
-test('opening should be empty for missing dates', (t, done) => {
+test('opening should be empty for missing dates', (_t, done) => {
   opening({}, (err, od) => {
     assert.ok(!od);
     done(err);
   });
 });
 
-test('opening should be empty for invalid dates', (t, done) => {
+test('opening should be empty for invalid dates', (_t, done) => {
   opening({
     opening: 'abc'
   }, (err, od) => {
@@ -30,7 +30,7 @@ test('opening should be empty for invalid dates', (t, done) => {
   });
 });
 
-test('opening should be empty for past dates', (t, done) => {
+test('opening should be empty for past dates', (_t, done) => {
   opening({
     opening: past
   }, (err, od) => {
@@ -39,7 +39,7 @@ test('opening should be empty for past dates', (t, done) => {
   });
 });
 
-test('opening should be empty for today', (t, done) => {
+test('opening should be empty for today', (_t, done) => {
   opening({
     opening: today
   }, (err, od) => {
@@ -48,7 +48,7 @@ test('opening should be empty for today', (t, done) => {
   });
 });
 
-test('opening should be present for future dates', (t, done) => {
+test('opening should be present for future dates', (_t, done) => {
   opening({
     opening: future
   }, (err, od) => {

test/weather/noaa.js

@@ -4,7 +4,7 @@ const noaa = require('../../lib/weather/noaa');
 
 require('../replay');
 
-test('noaa should return empty forecast if location is missing', (t, done) => {
+test('noaa should return empty forecast if location is missing', (_t, done) => {
   noaa({
     ll: [0, 0]
   }, (err, forecast) => {
@@ -14,7 +14,7 @@ test('noaa should return empty forecast if location is missing', (t, done) => {
   });
 });
 
-test('noaa should return forecast for valid location', (t, done) => {
+test('noaa should return forecast for valid location', (_t, done) => {
   noaa({
     // Killington, VT
     noaa: 'BTV/107,21',

test/weather/openweather.js

@@ -4,7 +4,7 @@ const openweather = require('../../lib/weather/openweather');
 
 require('../replay');
 
-test('openweather should return forecast', (t, done) => {
+test('openweather should return forecast', (_t, done) => {
   openweather({
     // Killington, VT
     ll: [-72.7933, 43.6647]

test/webcams.js

@@ -8,15 +8,15 @@ if (process.env.REPLAY !== 'record') {
   process.env.WEBCAMS_API_KEY = 'TEST_KEY';
 }
 
-test('webcams should return no webcams if location is missing', (t, done) => {
+test('webcams should return no webcams if location is missing', (_t, done) => {
   webcams({}, (err, webcams) => {
     assert.ifError(err);
     assert.ok(!webcams);
     done();
   });
 });
 
-test('webcams should return webcams for valid location', (t, done) => {
+test('webcams should return webcams for valid location', (_t, done) => {
   webcams({
     counter: 1,
     ll: [7.98, 46.54] // from API examples https://windy.com/webcams/1697038975'