Don't make SSL_CN mandatory #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the client didn't present a certificate, then there's no CN TLV that could be populated by the proxy. haproxy also omits this field in this case. The TLV is only appended if ssl_sock_get_remote_common_name returns a positive integer [1]. The function returns 0 in case the CN isn't found [2]. [1]: https://github.com/haproxy/haproxy/blob/233ad288cd4b855ba5fd08342433a0f5d20e625d/src/connection.c#L1510 [2]: https://github.com/haproxy/haproxy/blob/4299528390ce197a06c0ef1d59a4696fa9c19c30/src/ssl_sock.c#L6092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the client didn't present a certificate, then there's no CN TLV that
could be populated by the proxy.
haproxy also omits this field in this case. The TLV is only appended if
ssl_sock_get_remote_common_name returns a positive integer 1. The
function returns 0 in case the CN isn't found 2.