Conversation
|
@leeren Did you refer to any existing implementation from zkSync or others? If yes, can you paste the link here? |
|
As @limengformal mentioned, we need to be able to verify how much the precompile is modified if we are forking it from other client @leeren . Thanks! |
Yes, we mainly referenced op-geth Here is the main PR referenced:
The only diff is that we include the precompile in all forks as this is intended to be included on genesis. For iliad, this will be modified. |
LeoHChen
left a comment
LeoHChen
left a comment
There was a problem hiding this comment.
LGTM, I would like to see how can we test it e2e. Any impact to the downstream stack?
|
@leeren LGTM. Let's pick it to iliad branch and test in devnet |
leeren
force-pushed
the
feat/add-p256-verify
branch
2 times, most recently
from
6e7d8a7 to
ec6f9c1
Compare
Binary uploaded successfully 🎉📦 Version Name: 0.10.0-unstable-201dd6a |
leeren
force-pushed
the
feat/add-p256-verify
branch
from
ec6f9c1 to
7f3b1c3
Compare
fix(ipgraph): ensure stable ordering results
* feat(core/vm): adds eip-7212 precompile * update to support all fork sets
* feat(core/vm): adds eip-7212 precompile * update to support all fork sets
* feat(core/vm): adds eip-7212 precompile * update to support all fork sets
5 participants
Adds genesis precompile support for EIP-7212 precompiles.
To test, run
go test ./core/vm -run TestPrecompiledP256Verify.