-
Notifications
You must be signed in to change notification settings - Fork 210
Docs: Add V1 Control plane screenshot #6333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
| - **The Control Plane** can be thought of as a web service application that can be installed anywhere. It provides the web UI, API endpoints, and metadata storage. | ||
|
|
||
| - **Piped** is a lightweight agent that connects your infrastructure to the Control Plane. In PipeCD v1, Piped drops built-in platform support and uses a plugin-based model. Each plugin (an external component) implements the deployment and synchronization logic for a specific application kind, such as Kubernetes or Terraform. | ||
| - **Piped** is a lightweight agent that connects your infrastructure to the Control Plane. In PipeCD v1, each plugin (an external component) implements the deployment and synchronization logic for a specific application kind, such as Kubernetes or Terraform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to specify plugins here; no need to show too much information at once. Keep the quickstart as quickstart is better. Also, should not mention PipeCD v1 as discussed in this comment #6321 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to keep this same as quickstart for v0
PipeCD is constructed by two components: the Control plane and the piped (agent) (ref: PipeCD concepts). The control plane can be thought of as a regular web service application that can be installed anywhere, while the piped agent is a single binary that can run as a pod in a Kubernetes cluster, a container on ECS, a serverless function like Lambda, Cloud Run, or a process running directly on your local machine.
simply talk about pipecd controlplane and the piped, that can be installed anywhere
khanhtc1202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eeshaanSA, I have only a small concern about the quickstart header. Anything else lgtm 👍
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
@khanhtc1202 please check now! Thanks |
khanhtc1202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix/Docs Quickstart/add controlplane screenshot Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com> * grammar changes Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com> --------- Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
What this PR does:
Fix controlplane docs
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: