-
Notifications
You must be signed in to change notification settings - Fork 210
K8s plugin health status implementation #6320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6320 +/- ##
==========================================
+ Coverage 28.82% 28.85% +0.03%
==========================================
Files 560 560
Lines 59941 59993 +52
==========================================
+ Hits 17277 17313 +36
- Misses 41343 41359 +16
Partials 1321 1321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Warashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reference implementations are
| func determineDaemonSetHealth(obj *unstructured.Unstructured) (status model.KubernetesResourceState_HealthStatus, desc string) { |
| func determinePodHealth(obj *unstructured.Unstructured) (status model.KubernetesResourceState_HealthStatus, desc string) { |
What this PR does:
Implement health status check for resources:
Why we need it:
Which issue(s) this PR fixes:
Part of #5764
Follow #6303
Does this PR introduce a user-facing change?: