-
Notifications
You must be signed in to change notification settings - Fork 210
Docs: Add doc for migrating to v1 #6301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
@khanhtc1202 please check, thanks! |
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6301 +/- ##
==========================================
+ Coverage 28.75% 36.53% +7.77%
==========================================
Files 560 52 -508
Lines 59858 5338 -54520
==========================================
- Hits 17215 1950 -15265
+ Misses 41322 3282 -38040
+ Partials 1321 106 -1215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
cc @khanhtc1202 |
| ```bash | ||
| ./piped piped --config-file=<PATH_TO_PIPEDV1_CONFIG_FILE> --tools-dir=/tmp/piped-bin --insecure=true | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should mention that we also have pipedv1 as a container image, which is released here
https://github.com/pipe-cd/pipecd/pkgs/container/pipedv1-exp
So, if users prefer to install piped in any other way (such as in CloudRun, on VM, or ECS Fargate, etc.), which requires a container image of piped, they can use that published container image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a different option altogether or under Option 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khanhtc1202 what about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because the option 1 specifies to run piped using the helm command (including configmap and so on) to a Kubernetes cluster, while we can install piped just as a container in other platforms (like ecs fargate, cloud run service, etc), You can read about piped installation on the docs.
My point here is to add a note like: The container image of pipedv1 is available here (link provided), if users prefer to install piped in any other ways (such as in CloudRun, on VM, or ECS Fargate, etc.), which requires a container image of piped, they can use that published pipedv1 container image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @eeshaanSA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Making the changes.
Thanks!
|
Thanks @eeshaanSA , I left some comments. Also, please be sure links and mentioned versions refer to the same target as discussed here: #6301 (comment) |
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
fix typo Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
@khanhtc1202, made the changes. Please check. Thanks! |
khanhtc1202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👌
What this PR does:
Adds a page that helps user understand the process of safely migrating from pipedv0 to pipedv1.
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: