Skip to content

Implement application list pager #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Aug 12, 2020
Merged

Implement application list pager #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion pkg/app/web/src/components/application-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import {
TableHead,
TableRow,
Typography,
TablePagination,
TableFooter,
} from "@material-ui/core";
import MenuIcon from "@material-ui/icons/MoreVert";
import { Dictionary } from "@reduxjs/toolkit";
Expand Down Expand Up @@ -62,13 +64,17 @@ const EmptyDeploymentData: FC = () => (
</>
);

const PAGER_ROWS_PER_PAGE = [20, 50, { label: "All", value: -1 }];

export const ApplicationList: FC = memo(function ApplicationList() {
const classes = useStyles();
const dispatch = useDispatch<AppDispatch>();
const [anchorEl, setAnchorEl] = useState<HTMLButtonElement | null>(null);
const isOpenMenu = Boolean(anchorEl);
const [actionTarget, setActionTarget] = useState<Application | null>(null);
const [openDisableDialog, setOpenDisableDialog] = useState(false);
const [page, setPage] = React.useState(0);
const [rowsPerPage, setRowsPerPage] = React.useState(20);

const applications = useSelector<AppState, Application[]>((state) =>
selectAll(state.applications)
Expand Down Expand Up @@ -124,7 +130,13 @@ export const ApplicationList: FC = memo(function ApplicationList() {
</TableRow>
</TableHead>
<TableBody>
{applications.map((app) => {
{(rowsPerPage > 0
? applications.slice(
page * rowsPerPage,
page * rowsPerPage + rowsPerPage
)
: applications
).map((app) => {
const recentlyDeployment = app.mostRecentlySuccessfulDeployment;
return (
<TableRow key={`app-${app.id}`}>
Expand Down Expand Up @@ -185,6 +197,24 @@ export const ApplicationList: FC = memo(function ApplicationList() {
);
})}
</TableBody>
<TableFooter>
<TableRow>
<TablePagination
rowsPerPageOptions={PAGER_ROWS_PER_PAGE}
count={applications.length}
rowsPerPage={rowsPerPage}
page={page}
colSpan={8}
onChangePage={(_, newPage) => {
setPage(newPage);
}}
onChangeRowsPerPage={(e) => {
setRowsPerPage(parseInt(e.target.value, 10));
setPage(0);
}}
/>
</TableRow>
</TableFooter>
</Table>
</TableContainer>

Expand Down