Skip to content

Ensure to ignore Commit Mather when triggered by a command #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Aug 5, 2020
Merged

Ensure to ignore Commit Mather when triggered by a command #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/app/piped/planner/kubernetes/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ func (p *Planner) Plan(ctx context.Context, in planner.Input) (out planner.Outpu
}

// This deployment is triggered by a commit with the intent to perform pipeline.
if p := cfg.CommitMatcher.Pipeline; p != "" {
// Commit Matcher will be ignored when triggered by a command.
if p := cfg.CommitMatcher.Pipeline; p != "" && in.Deployment.Trigger.Commander == "" {
pipelineRegex, err := in.RegexPool.Get(p)
if err != nil {
err = fmt.Errorf("failed to compile commitMatcher.pipeline(%s): %w", p, err)
Expand All @@ -104,7 +105,8 @@ func (p *Planner) Plan(ctx context.Context, in planner.Input) (out planner.Outpu
}

// This deployment is triggered by a commit with the intent to synchronize.
if s := cfg.CommitMatcher.QuickSync; s != "" {
// Commit Matcher will be ignored when triggered by a command.
if s := cfg.CommitMatcher.QuickSync; s != "" && in.Deployment.Trigger.Commander == "" {
syncRegex, err := in.RegexPool.Get(s)
if err != nil {
err = fmt.Errorf("failed to compile commitMatcher.sync(%s): %w", s, err)
Expand Down