Skip to content

Treat json as a manifest #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Jul 31, 2020
Merged

Treat json as a manifest #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/app/piped/cloudprovider/kubernetes/manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string) ([]
return filepath.SkipDir
}
ext := filepath.Ext(f.Name())
if ext != ".yaml" && ext != ".yml" {
if ext != ".yaml" && ext != ".yml" && ext != ".json" {
return nil
}
// TODO: Allow to check other than default configuration name too
Expand All @@ -193,7 +193,7 @@ func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string) ([]
path := filepath.Join(dir, name)
ms, err := LoadManifestsFromYAMLFile(path)
if err != nil {
return nil, fmt.Errorf("failed to load maninifest at %s (%v)", path, err)
return nil, fmt.Errorf("failed to load maninifest at %s (%w)", path, err)
}
manifests = append(manifests, ms...)
}
Expand Down