Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Fix the sidebar index showing unexpected templates, like this

Screenshot 2024-08-19 at 10 14 53

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc
t-kikuc previously approved these changes Aug 19, 2024
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
Since v0.49.0 will be released soon, we don't need to fix v0.48.x

Signed-off-by: khanhtc1202 <[email protected]>
@khanhtc1202
Copy link
Member Author

thanks Since v0.49.0 will be released soon, we don't need to fix v0.48.x

Sorry, I want to update docs v0.48.x as well, please re-approve

@khanhtc1202 khanhtc1202 requested a review from t-kikuc August 19, 2024 03:20
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) August 19, 2024 03:22
@codecov
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.79%. Comparing base (71b46e0) to head (9df8271).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5147   +/-   ##
=======================================
  Coverage   22.79%   22.79%           
=======================================
  Files         412      412           
  Lines       43827    43827           
=======================================
  Hits         9989     9989           
  Misses      33050    33050           
  Partials      788      788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 merged commit 08a777b into master Aug 19, 2024
@khanhtc1202 khanhtc1202 deleted the fix-pipectl-install-docs branch August 19, 2024 04:28
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants