Skip to content

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Aug 2, 2024

What this PR does / why we need it:

Upgrade the Grafana sub-chart in the pipecd chart.

Which issue(s) this PR fixes:

Part of #4431

Does this PR introduce a user-facing change?: Yes

  • How are users affected by this change:
    The control plane manager who uses the pipecd charts and specifies the non-default image registry for the Grafana sub-chart
  • Is this breaking change:
    Yes
  • How to migrate (if breaking change):
    Specify image registry not with grafana.global.image.registry but with grafana.global.imageRegistry.

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@codecov
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.80%. Comparing base (23d338f) to head (0ce5f68).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5103      +/-   ##
==========================================
- Coverage   22.83%   22.80%   -0.03%     
==========================================
  Files         409      409              
  Lines       43338    43338              
==========================================
- Hits         9895     9885      -10     
- Misses      32665    32674       +9     
- Partials      778      779       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi
Copy link
Member Author

Warashi commented Aug 2, 2024

oops, something strange...

image

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi
Copy link
Member Author

Warashi commented Aug 2, 2024

I fixed it by modifying ConfigMap mounted directories.

image

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Warashi Warashi merged commit f9e91eb into master Aug 6, 2024
@Warashi Warashi deleted the bump-grafana branch August 6, 2024 04:32
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants