Skip to content

Cherry-pick #5063 #5072 #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
Closed

Cherry-pick #5063 #5072 #5084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8140778
add EphemeralStorage to RegisterTaskDefinition() (#5063)
t-kikuc Jul 23, 2024
4c283fc
Fix type for grpcWeb.Error to grpcweb.RpcError (#5072)
ffjlabo Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/app/piped/platformprovider/ecs/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ func (c *client) RegisterTaskDefinition(ctx context.Context, taskDefinition type
NetworkMode: taskDefinition.NetworkMode,
Volumes: taskDefinition.Volumes,
RuntimePlatform: taskDefinition.RuntimePlatform,
EphemeralStorage: taskDefinition.EphemeralStorage,
// Requires defined at task level in case Fargate is used.
Cpu: taskDefinition.Cpu,
Memory: taskDefinition.Memory,
Expand Down
2 changes: 1 addition & 1 deletion web/src/api/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const apiClient = new WebServiceClient(apiEndpoint, null, {
});

interface ApiCallback<Res> {
(err: grpcWeb.Error, response: { toObject: () => Res }): void;
(err: grpcWeb.RpcError, response: { toObject: () => Res }): void;
}

export async function apiRequest<Req, Res>(
Expand Down