Skip to content

Conversation

@t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jul 25, 2024

What this PR does / why we need it:

Remove 2 unused dependencies:

  • @date-io/dayjs
  • @material-ui/pickers

(listed by npx depcheck)

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

@codecov
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.72%. Comparing base (60c4a53) to head (5cc09af).
Report is 659 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5070      +/-   ##
==========================================
- Coverage   22.73%   22.72%   -0.01%     
==========================================
  Files         410      410              
  Lines       43514    43514              
==========================================
- Hits         9892     9889       -3     
- Misses      32844    32847       +3     
  Partials      778      778              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@t-kikuc t-kikuc enabled auto-merge (squash) July 25, 2024 02:35
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@t-kikuc t-kikuc merged commit 67bc2a9 into master Jul 25, 2024
@t-kikuc t-kikuc deleted the remove-unused-dep-web branch July 25, 2024 07:20
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
ffjlabo pushed a commit that referenced this pull request Jul 29, 2024
* yarn remove @date-io/dayjs

Signed-off-by: t-kikuc <[email protected]>

* yarn remove @material-ui/pickers

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
t-kikuc added a commit that referenced this pull request Jul 29, 2024
)

* fix: upgrade dotenv from 8.2.0 to 8.6.0 (#5037)

Snyk has created this PR to upgrade dotenv from 8.2.0 to 8.6.0.

See this package in yarn:
dotenv

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* fix: upgrade @types/yup from 0.29.11 to 0.29.14 (#5038)

Snyk has created this PR to upgrade @types/yup from 0.29.11 to 0.29.14.

See this package in yarn:
@types/yup

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* fix: upgrade react-draggable from 4.4.3 to 4.4.6 (#5039)

Snyk has created this PR to upgrade react-draggable from 4.4.3 to 4.4.6.

See this package in yarn:
react-draggable

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* fix: upgrade clsx from 1.1.1 to 1.2.1 (#5040)

Snyk has created this PR to upgrade clsx from 1.1.1 to 1.2.1.

See this package in yarn:
clsx

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* add EphemeralStorage to RegisterTaskDefinition() (#5063)

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* Remove platform provider migration ops task (#5065)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* Remove unused dependencies: @date-io/dayjs, @material-ui/pickers (#5070)

* yarn remove @date-io/dayjs

Signed-off-by: t-kikuc <[email protected]>

* yarn remove @material-ui/pickers

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix type for grpcWeb.Error to grpcweb.RpcError (#5072)

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Release/init v0.48.3 (#5090)

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants